Skip to content

[Reputation Oracle] refactor: use module ref for factory method #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnechay merged 1 commit into from
Jun 13, 2025
Merged

[Reputation Oracle] refactor: use module ref for factory method #3390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions .../apps/reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
OperatorUtils,
} from '@human-protocol/sdk';
import { Injectable } from '@nestjs/common';
import { ModuleRef } from '@nestjs/core';

import crypto from 'crypto';
import { ethers } from 'ethers';
Expand Down Expand Up @@ -60,12 +61,7 @@ export class EscrowCompletionService {
private readonly storageService: StorageService,
private readonly outgoingWebhookService: OutgoingWebhookService,
private readonly reputationService: ReputationService,
private readonly audinoResultsProcessor: AudinoResultsProcessor,
private readonly cvatResultsProcessor: CvatResultsProcessor,
private readonly fortuneResultsProcessor: FortuneResultsProcessor,
private readonly audinoPayoutsCalculator: AudinoPayoutsCalculator,
private readonly cvatPayoutsCalculator: CvatPayoutsCalculator,
private readonly fortunePayoutsCalculator: FortunePayoutsCalculator,
private readonly moduleRef: ModuleRef,
) {}

async createEscrowCompletion(
Expand Down Expand Up @@ -441,15 +437,15 @@ export class EscrowCompletionService {
jobRequestType: JobRequestType,
): EscrowResultsProcessor {
if (manifestUtils.isFortuneJobType(jobRequestType)) {
return this.fortuneResultsProcessor;
return this.moduleRef.get(FortuneResultsProcessor);
}

if (manifestUtils.isCvatJobType(jobRequestType)) {
return this.cvatResultsProcessor;
return this.moduleRef.get(CvatResultsProcessor);
}

if (manifestUtils.isAudinoJobType(jobRequestType)) {
return this.audinoResultsProcessor;
return this.moduleRef.get(AudinoResultsProcessor);
}

throw new Error(
Expand All @@ -461,15 +457,15 @@ export class EscrowCompletionService {
jobRequestType: JobRequestType,
): EscrowPayoutsCalculator {
if (manifestUtils.isFortuneJobType(jobRequestType)) {
return this.fortunePayoutsCalculator;
return this.moduleRef.get(FortunePayoutsCalculator);
}

if (manifestUtils.isCvatJobType(jobRequestType)) {
return this.cvatPayoutsCalculator;
return this.moduleRef.get(CvatPayoutsCalculator);
}

if (manifestUtils.isAudinoJobType(jobRequestType)) {
return this.audinoPayoutsCalculator;
return this.moduleRef.get(AudinoPayoutsCalculator);
}

throw new Error(
Expand Down