Issue 3387: Custom logging package - #3409
Closed
santail wants to merge 14 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
santail
requested review from
flopez7 and
portuu3
and removed request for
portuu3
June 23, 2025 14:40
added 6 commits
June 23, 2025 17:42
santail
force-pushed
the
nikolai/3387-Custom-logging-package
branch
from
June 23, 2025 14:42
033f3dd to
ff7f03d
Compare
flopez7
reviewed
Jun 24, 2025
flopez7
left a comment
flopez7
left a comment
Contributor
There was a problem hiding this comment.
Overall, the code looks good.
Anyway, I suggest updating the logger initialization so each service can specify its own service name. This way, logs will clearly indicate which service they belong to, making it much easier to trace issues in a multi-service environment.
It would be great if the logger library exposed a function to create a logger instance with a custom service name, and then we could use that in each main.ts (e.g., createServiceLogger('job-launcher'))
Collaborator
|
@dnechay could you please take a quick look? just to make sure what you did for logging is not broken |
dnechay
self-requested a review
July 3, 2025 16:47
Collaborator
|
Closing in favor of #3451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3387
Context behind the change
Create a custom logging package that will be reused in services and oracles
How has this been tested?
While running application locally, verified log is written
Checked errors logs are written
Verified logger.info is called properly and logs are written respectively
Release plan
Nothing special, all dependencies should be there.
Potential risks; What to monitor; Rollback plan
Some logs are missing due to misuse in code