fix: node sdk publish - #3419
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dnechay
marked this pull request as ready for review
June 26, 2025 14:12
portuu3
approved these changes
Jun 26, 2025
This was referenced Jun 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
No
Context behind the change
SDK package fails to be installed because its "core" package dependency isn't replaced properly while doing "publish". It's due to CI using some custom publish action instead of relying on native mechanism in
yarnthat should properly replace deps when doing publish in workspaces (ref).Also had to change
corepackage resolution to beworkspace:xinstead ofworkspace:*in order to:coreversion for developmentworkspace:*- yarn will replace it with the exact version from core's package.json when packing; as an alternative could beworkspace:>=0.0.0How has this been tested?
yarn packfrom SDK workspace and check that resultingpackage.jsonhas"@human-protocol/core": "x"in its depsRelease plan
Merge & release 4.1.2
Potential risks; What to monitor; Rollback plan
We need to run action to see if it works, but in worst case it just fails