[Reputation Oracle] fix: get improted provider ref - #3428
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
This reverts commit 0d2b626.
dnechay
force-pushed
the
dnechay/fix-providers
branch
from
June 30, 2025 11:51
0d2b652 to
a8260d2
Compare
Dzeranov
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
N/A
Context behind the change
After #3390 RepO fails to get some providers from the module DI container because
moduleRefby default is scoped to the current module only (which is not clear on "how" from their docs). In order to retrieve a provider from a global context (i.e. from imported modules) thestring: falseshould be passed, so in order to avoid confusing we decided to get back explicit providers injectionHow has this been tested?
Release plan
Just merge
Potential risks; What to monitor; Rollback plan
Should be none