Skip to content

[Job Launcher] feat: use shared logger - #3456

Merged
dnechay merged 4 commits into
developfrom
dnechay/jl-structured-log
Jul 11, 2025
Merged

[Job Launcher] feat: use shared logger#3456
dnechay merged 4 commits into
developfrom
dnechay/jl-structured-log

Conversation

@dnechay

@dnechay dnechay commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Issue tracking

Follow up to #3387. Closes #3388

Context behind the change

Applied shared logger in order to use structured logging.

Changed scripts in root package.json to rely on yarn workspace features in order:

  • build packages in parallel
  • easily build them in topological order (i.e. sub-dependencies first)
  • easily build all packages/libs
  • fix yarn build:libs command failure due to absence of logger workspace in some docker images

How has this been tested?

  • unit tests
  • run JL in docker, make sure service runs and logs are written in correct format

Release plan

  1. Update NODE_ENV on render for JL to correspond to actual environment (i.e. staging or production, right now it's development on staging)
  2. Enable logs sending from JL -> DataDog on Render

Potential risks; What to monitor; Rollback plan

Should be none

@vercel

vercel Bot commented Jul 10, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 10:29pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 10:29pm
human-app ⬜️ Skipped (Inspect) Jul 10, 2025 10:29pm
human-dashboard-frontend ⬜️ Skipped (Inspect) Jul 10, 2025 10:29pm
staking-dashboard ⬜️ Skipped (Inspect) Jul 10, 2025 10:29pm

Comment thread packages/apps/job-launcher/server/src/database/database.module.ts
@dnechay
dnechay force-pushed the dnechay/jl-structured-log branch from 31ad4d4 to 15b8ade Compare July 10, 2025 22:28
@vercel
vercel Bot temporarily deployed to Preview – staking-dashboard July 10, 2025 22:28 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-dashboard-frontend July 10, 2025 22:28 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-app July 10, 2025 22:28 Inactive
@dnechay
dnechay requested a review from flopez7 July 10, 2025 22:30

@flopez7 flopez7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm

Comment thread package.json
@dnechay
dnechay requested a review from flopez7 July 11, 2025 13:01
@dnechay
dnechay merged commit e8e4296 into develop Jul 11, 2025
13 checks passed
@dnechay
dnechay deleted the dnechay/jl-structured-log branch July 11, 2025 14:12
@github-project-automation github-project-automation Bot moved this from In Review to Done in Core-tech - 2025 Jul 11, 2025
@dnechay dnechay mentioned this pull request Jul 11, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Job Launcher] Use logging package

2 participants