[Staking] Wallet connect not working - #3473
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
KirillKirill
force-pushed
the
kb/3468-wallet-connect-bug
branch
from
July 25, 2025 10:26
17887ab to
3c85a25
Compare
KirillKirill
marked this pull request as ready for review
July 25, 2025 10:32
dnechay
approved these changes
Jul 25, 2025
portuu3
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Closes #3468
Context behind the change
If a user wants to connect their wallet via WalletConnect, the app triggers metamask regardless. This occurs due to we invoke
window.ethereumafter a wallet gets connected, which always triggers metamask.How has this been tested?
tested with Trust and Mixin wallets
Release plan
regular
Potential risks; What to monitor; Rollback plan
haven't been found