[Fortune] feat: use shared logger - #3493
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
flopez7
suggested changes
Aug 6, 2025
flopez7
left a comment
flopez7
left a comment
Contributor
There was a problem hiding this comment.
Don't add whitespace separating import logic blocks. We have eslint auto-order configured, and if there are blank lines, imports won't be ordered correctly and we'll have to fix them manually
dnechay
force-pushed
the
dnechay/fs-050825
branch
from
August 6, 2025 11:40
f506543 to
b9dfe69
Compare
flopez7
approved these changes
Aug 6, 2025
Dzeranov
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Follow up to #3387
Context behind the change
Added shared logger to Fortune for ease of debugging on staging.
How has this been tested?
Release plan
NODE_ENVon render for Fortune services to correspond to actual environment (staging)Potential risks; What to monitor; Rollback plan
Check that logs are displayed correctly in DD.