Skip to content

refactor: remove unnecessary logs from services - #3497

Merged
dnechay merged 8 commits into
developfrom
dnechay/fs-080825
Aug 8, 2025
Merged

refactor: remove unnecessary logs from services#3497
dnechay merged 8 commits into
developfrom
dnechay/fs-080825

Conversation

@dnechay

@dnechay dnechay commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

Issue tracking

Freestyle

Context behind the change

In DD we found out that:

  • dashboard has unhandled errors in scheduled jobs that are logger by global Nest error handler
  • Fortune RecO & JL log 4xx errors as "unhandled", even though we don't need them
  • too many Function execution failed for key errors coming from JL

In this PR remove unnecessary logging & fix mutex errors handling in JL.
Also changed HUMAN App status codes to be 200 instead of 201 where needed & removed useless e2e tests from it.

How has this been tested?

  • run JL locally, make sure proper errors thrown from quick-launch
  • run Fortune RecO, hit random route, make sure 404 not logged anymore
  • run Dashboard server with invalid API keys fro hCaptcha stats, wait for cron/init, make sure errors logged properly
  • run HUMAN App locally and click through endpoints

Release plan

Merge. Check that unnecessary logs are gone after deployment.
Add job launcher logs to monitors on datadog.

Potential risks; What to monitor; Rollback plan

No

@dnechay dnechay self-assigned this Aug 8, 2025
@dnechay dnechay moved this to In Progress in Core-tech - 2025 Aug 8, 2025
@vercel

vercel Bot commented Aug 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2025 10:36am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2025 10:36am
human-app ⬜️ Skipped (Inspect) Aug 8, 2025 10:36am
human-dashboard-frontend ⬜️ Skipped (Inspect) Aug 8, 2025 10:36am
staking-dashboard ⬜️ Skipped (Inspect) Aug 8, 2025 10:36am

@vercel
vercel Bot temporarily deployed to Preview – human-app August 8, 2025 09:01 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-dashboard-frontend August 8, 2025 09:01 Inactive
@vercel
vercel Bot temporarily deployed to Preview – staking-dashboard August 8, 2025 09:01 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-app August 8, 2025 09:11 Inactive
@vercel
vercel Bot temporarily deployed to Preview – staking-dashboard August 8, 2025 09:11 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-dashboard-frontend August 8, 2025 09:11 Inactive
@dnechay
dnechay requested a review from Dzeranov August 8, 2025 09:11
@dnechay dnechay moved this from In Progress to In Review in Core-tech - 2025 Aug 8, 2025
@vercel
vercel Bot temporarily deployed to Preview – staking-dashboard August 8, 2025 10:32 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-dashboard-frontend August 8, 2025 10:32 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-app August 8, 2025 10:35 Inactive
@vercel
vercel Bot temporarily deployed to Preview – staking-dashboard August 8, 2025 10:35 Inactive
@vercel
vercel Bot temporarily deployed to Preview – human-dashboard-frontend August 8, 2025 10:35 Inactive
@dnechay dnechay mentioned this pull request Aug 8, 2025
15 tasks
@dnechay
dnechay requested a review from flopez7 August 8, 2025 11:05
@dnechay
dnechay merged commit b7918e3 into develop Aug 8, 2025
17 checks passed
@dnechay
dnechay deleted the dnechay/fs-080825 branch August 8, 2025 13:40
@github-project-automation github-project-automation Bot moved this from In Review to Done in Core-tech - 2025 Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants