Skip to content

[Reputation Oracle] fix on-chain staked balance calculation #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flopez7 merged 2 commits into from
Jan 8, 2026
Merged

[Reputation Oracle] fix on-chain staked balance calculation #3735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71eada5
fix on-chain staked balance calculation
flopez7 Jan 8, 2026
505f27d
update getOnChainStakedBalance test to return only total staked balance
flopez7 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions packages/apps/reputation-oracle/server/src/modules/staking/staking.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,22 +169,17 @@ describe('StakingService', () => {
});

describe('getOnChainStakedBalance', () => {
it('returns total staked and locked balance', async () => {
it('returns total staked balance', async () => {
const address = faker.finance.ethereumAddress();
const stakedAmount = ethers.toBigInt(
faker.number.int({ min: 500, max: 1000000 }),
);
const lockedAmount = ethers.toBigInt(
faker.number.int({ min: 500, max: 999999 }),
);
const mockProvider = {};
mockWeb3Service.getSigner.mockReturnValueOnce({
provider: mockProvider,
} as WalletWithProvider);

const getStakerInfoMock = jest
.fn()
.mockResolvedValue({ stakedAmount, lockedAmount });
const getStakerInfoMock = jest.fn().mockResolvedValue({ stakedAmount });
mockedStakingClient.build.mockResolvedValueOnce({
getStakerInfo: getStakerInfoMock,
} as unknown as StakingClient);
Expand All @@ -193,9 +188,7 @@ describe('StakingService', () => {

expect(mockedStakingClient.build).toHaveBeenCalledWith(mockProvider);
expect(getStakerInfoMock).toHaveBeenCalledWith(address);
expect(result).toBe(
Number(ethers.formatEther(stakedAmount + lockedAmount)),
);
expect(result).toBe(Number(ethers.formatEther(stakedAmount)));
});
});

Expand Down
4 changes: 1 addition & 3 deletions packages/apps/reputation-oracle/server/src/modules/staking/staking.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ export class StakingService {
const stakingClient = await StakingClient.build(provider);
const stakerInfo = await stakingClient.getStakerInfo(address);

const total =
(stakerInfo.stakedAmount ?? 0n) + (stakerInfo.lockedAmount ?? 0n);
return Number(ethers.formatEther(total));
return Number(ethers.formatEther(stakerInfo.stakedAmount ?? 0n));
}

async getStakeSummary(userId: number): Promise<StakeSummaryData> {
Expand Down
Loading