[SDK] Enhance transaction handling with wait options - #3744
Merged
Conversation
… Staking clients - Updated KVStoreClient and StakingClient to utilize TransactionOverrides for transaction options, allowing for customizable wait parameters (confirmations and timeout). - Refactored methods to ensure proper handling of transaction confirmations and timeouts during contract interactions. - Added tests to verify that wait options are correctly passed to transaction wait calls in both clients.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
portuu3
previously approved these changes
Jan 22, 2026
dnechay
previously approved these changes
Jan 22, 2026
dnechay
approved these changes
Jan 23, 2026
Collaborator
|
@flopez7 might make sense to use these new timeout options in JL & RepO as part of this PR |
Contributor
Author
|
I'd do it in a new PR @dnechay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3716
Context behind the change
How has this been tested?
Created some transactions manually with different configurations to make it fail.
Ran unit tests.
Release plan
Deploy new SDK version.
Potential risks; What to monitor; Rollback plan
Python SDK has been significantly changed to introduce confirmation logic. If we don't specify confirmations, it should work as usual.