Skip to content

complete escrows without payouts #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
portuu3 merged 2 commits into from
May 29, 2026
Merged

complete escrows without payouts #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41663d0
complete escrows without payouts
May 28, 2026
a764800
test: update escrow completion tests to include Pending status and im…
May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .../reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ describe('EscrowCompletionService', () => {
});
});

it.each([EscrowStatus.Partial, EscrowStatus.Paid])(
it.each([EscrowStatus.Partial, EscrowStatus.Paid, EscrowStatus.Pending])(
'should properly complete escrow with status "%s"',
async (escrowStatus) => {
mockedEscrowUtils.getEscrow.mockResolvedValueOnce({
Expand Down Expand Up @@ -1123,12 +1123,8 @@ describe('EscrowCompletionService', () => {
},
);

it.each([
EscrowStatus.Cancelled,
EscrowStatus.Pending,
EscrowStatus.Complete,
])(
'should not comlete escrow if its status is not partial or paid [%#]',
it.each([EscrowStatus.Cancelled, EscrowStatus.Complete])(
'should not complete escrow if its status is not completable [%#]',
async (escrowStatus) => {
mockedEscrowUtils.getEscrow.mockResolvedValueOnce({
launcher: launcherAddress,
Expand Down
5 changes: 4 additions & 1 deletion .../apps/reputation-oracle/server/src/modules/escrow-completion/escrow-completion.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export class EscrowCompletionService {
const escrowStatus = await escrowClient.getStatus(
escrowCompletionEntity.escrowAddress,
);
let toComplete = false;
if (
escrowStatus === EscrowStatus.Pending ||
escrowStatus === EscrowStatus.ToCancel
Expand Down Expand Up @@ -167,6 +168,7 @@ export class EscrowCompletionService {
finalResultsUrl: escrowCompletionEntity.finalResultsUrl,
});

toComplete = calculatedPayouts.length === 0;
/**
* When creating payout batches we need to guarantee deterministic result,
* so order it first.
Expand Down Expand Up @@ -198,7 +200,7 @@ export class EscrowCompletionService {
}

escrowCompletionEntity.status = EscrowCompletionStatus.AWAITING_PAYOUTS;
if (escrowStatus === EscrowStatus.Cancelled) {
if (escrowStatus === EscrowStatus.Cancelled || toComplete) {
escrowCompletionEntity.status = EscrowCompletionStatus.PAID;
}
await this.escrowCompletionRepository.updateOne(escrowCompletionEntity);
Expand Down Expand Up @@ -241,6 +243,7 @@ export class EscrowCompletionService {
EscrowStatus.Partial,
EscrowStatus.Paid,
EscrowStatus.ToCancel,
EscrowStatus.Pending,
].includes(escrowStatus)
) {
const feeOverrides = await this.web3Service.calculateTxFees(chainId);
Expand Down
Loading