Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates LLVM's lit testing framework into the project, adding the necessary CMake configurations, site templates, and updating existing test files to use lit-style CHECK lines. The changes include the addition of test/lit/CMakeLists.txt, lit.cfg.py, and lit.site.cfg.py.in, alongside significant updates to various .pto test files to reflect changes in generated code and error reporting. Several issues were identified in the new build scripts, including a potential copy-paste error where dependencies were appended to the wrong variable (MLIR_TEST_DEPENDS instead of PTOIR_TEST_DEPENDS), redundant configuration of %PATH% and test_exec_root in the Python config, and the inclusion of a potentially non-existent dependency pto-opt.
Codex Review该评论由 review 机器人自动更新。
Summarylit registration misses one existing A5 regression test, and the new lit environment is not runnable on macOS because it does not preserve Findings
The new suite only discovers tests under
The lit config forwards only |
|
/run sim |
|
/run all |
A3 板测完成(有跳过)
|
|
/run sim |
|
/run a5 |
|
A5 手动板测当前要求显式指定 case。请使用 |
This PR adds a target to register and run the lit (FileCheck) tests.
Changes
check-ptoto run the testsIMPORTANT
pto/issue481_addptr_gm_slot_buffer.ptofails. This is a genuine bug.