Refactor: rename dump-tensor public surface to dump-args (#1075)#1143
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates the A2A3 DFX smoke path to use ChangesArgs-dump naming rollout
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the 'tensor dump' feature to 'args dump' across various documentation files, code comments, examples, and test cases to ensure consistent terminology. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
doraemonmj
force-pushed
the
rename-dump-args-1075
branch
from
5604485 to
a053568
Compare
|
PR1143 rename remaining items (exclude host_build_graph example rename) Scope:
Current text: Expected rename: Reason:
Current text in the feature comparison table: Expected rename: Reason:
These are comments only. They were introduced by PR1100 merge commit: Current wording pattern: Expected rename: Files/lines currently containing the old wording: Reason: |
…ys#1075) PR hw-native-sys#1072 renamed the --dump-args CLI flag, the args_dump/ artifact directory, the manifest, and the dump_viewer tool, but left several user-facing surfaces still naming the legacy "dump tensor" feature. The feature semantics are per-task argument dump, so finish the rename: - Rename the dfx smoke test dir + file tensor_dump/test_tensor_dump.py -> args_dump/test_args_dump.py and class TestTensorDump -> TestArgsDump (plus its output-label string) - Update both ci.yml jobs: step name and test path - Rename docs/dfx/tensor-dump.md -> args-dump.md and fix all inbound links (tools/README, src/{a2a3,a5}/docs/runtimes.md, profiling-framework) - Fix stale comments/README naming the renamed public surface: the old --dump-tensor flag (task_interface.cpp, vector_add README) and the old tensor_dump/ output dir (call_config.h, device_runner_base.h) Internal C++ implementation names (CallConfig::enable_dump_tensor, TensorDumpCollector, etc.) are intentionally left unchanged — out of scope for a public-surface rename. The host_build_graph dump_tensor examples are also untouched: they genuinely demonstrate the tensor-info dump APIs (set_tensor_info_to_task), not the unified args-dump feature.
doraemonmj
force-pushed
the
rename-dump-args-1075
branch
from
a053568 to
09dab94
Compare
已修改 |
|
@vegetabledoww 已修改 |
3 participants
What
Finishes the public-surface rename started in #1072. That PR renamed the
--dump-argsCLI flag, theargs_dump/artifact directory, the manifest,and the
dump_viewertool, but several user-facing surfaces still named thelegacy dump tensor feature. The feature semantics are per-task argument
dump, so this completes the rename across tests, CI, and docs (issue #1075).
Changes
dfx/tensor_dump/test_tensor_dump.py→dfx/args_dump/test_args_dump.py; classTestTensorDump→TestArgsDump(and its output-label string).
ci.ymljobs — step nametensor_dump smoke→args_dump smokeand the test path.
docs/dfx/tensor-dump.md→args-dump.mdwith all inbound linksfixed (
tools/README.md,src/{a2a3,a5}/docs/runtimes.md,profiling-framework.md).--dump-tensorflag (task_interface.cpp,vector_add/README.md) and theold
tensor_dump/output dir (call_config.h,device_runner_base.h).Out of scope (intentionally untouched)
CallConfig::enable_dump_tensor,TensorDumpCollector, etc.) — not part of the public surface.host_build_graph/dump_tensorexamples — they genuinely demonstrate thetensor-info dump APIs (
set_tensor_info_to_task), not the unified args-dumpfeature, so their name is correct.
No behavior change — renames and comment/doc fixes only.