Add: Add the synchronization statement for the a5 use case#586
Merged
ChaoZheng109 merged 1 commit intohw-native-sys:mainfrom Apr 17, 2026
Merged
Add: Add the synchronization statement for the a5 use case#586ChaoZheng109 merged 1 commit intohw-native-sys:mainfrom
ChaoZheng109 merged 1 commit intohw-native-sys:mainfrom
Conversation
Contributor
doraemonmj
commented
Apr 16, 2026
doraemonmj
commented
- Add synchronization statements in the relevant kernels of host_build_graph and tensormap_and_ringbuffer
- Make sure that the synchronization statements will be executed before the process ends
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces synchronization points using EVENT_ID7 across multiple kernel implementations to ensure data visibility between the FIX/MTE3 and S pipes. However, the review feedback identifies a significant performance concern: placing these synchronization calls inside core implementation functions (such as matmul_impl, add_impl, and mul_impl) leads to pipeline stalls during every tile iteration. To avoid this bottleneck and maintain efficient overlapping of memory transfers and compute, the synchronization should be moved to the end of the kernel_entry functions after the processing loops have finished.
- Add synchronization statements in the relevant kernels of host_build_graph and tensormap_and_ringbuffer - Make sure that the synchronization statements will be executed before the process ends
ChaoZheng109
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.