Simplify AicpuExecutor API and unify naming conventions#7
Closed
ChaoZheng109 wants to merge 1 commit into
Closed
Conversation
ChaoZheng109
force-pushed
the
runtime-args2
branch
from
0346308 to
dce3fc7
Compare
## Summary This PR simplifies the AICPU executor interface and improves code consistency through refactoring and renaming. ## Changes - **Rename**: `runtimeexecutor.cpp` → `aicpu_executor.cpp`, `RuntimeExecutor` → `AicpuExecutor` - **Remove redundant parameter**: Removed `runtimeCtx` from `KernelArgs` structure - **Simplify API**: Reduced redundant input parameters in executor methods - **Unify naming**: Changed global variable `g_executor` → `g_aicpu_executor` for better clarity ## Files Changed - `src/runtime/aicpu/runtimeexecutor.cpp` → `src/runtime/aicpu/aicpu_executor.cpp` - `src/platform/a2a3/aicpu/kernel.cpp` - `src/platform/a2a3/common/kernel_args.h` - `src/platform/a2a3/host/devicerunner.cpp` - `example/main.py` ## Impact - Cleaner and more consistent naming convention - Simplified function signatures with fewer parameters - No functional behavior changes
ChaoZheng109
force-pushed
the
runtime-args2
branch
from
dce3fc7 to
b3c7cca
Compare
ChaoWao
added a commit
to ChaoWao/simpler-fork
that referenced
this pull request
Jun 26, 2026
…tgun - running-onboard: redirect device logs via ASCEND_PROCESS_LOG_PATH (export == --env); add a 507018 triage table (deadlock-detect vs SPIN-timeout vs OS op-timeout vs forward-progress stall) so a generic host 507018 is classified from the device log. - new dfx-analyze skill: reach for simpler's built-in DFX tools (device_log_timing, swimlane_converter, sched_overhead_analysis, deps_viewer, dump_viewer) instead of hand-rolling timing/instrumentation in the runtime. - codestyle rule hw-native-sys#7: never log on AICPU hot paths (floods device_log -> op-timeout, masking the behavior under study). - multi-repo-setup: non-editable reinstall can silently skip the runtime .so rebuild; verify the built .so changed or cmake --build the cache + sync to both load locations.
ChaoWao
added a commit
that referenced
this pull request
Jun 26, 2026
…tgun (#1163) - running-onboard: redirect device logs via ASCEND_PROCESS_LOG_PATH (export == --env); add a 507018 triage table (deadlock-detect vs SPIN-timeout vs OS op-timeout vs forward-progress stall) so a generic host 507018 is classified from the device log. - new dfx-analyze skill: reach for simpler's built-in DFX tools (device_log_timing, swimlane_converter, sched_overhead_analysis, deps_viewer, dump_viewer) instead of hand-rolling timing/instrumentation in the runtime. - codestyle rule #7: never log on AICPU hot paths (floods device_log -> op-timeout, masking the behavior under study). - multi-repo-setup: non-editable reinstall can silently skip the runtime .so rebuild; verify the built .so changed or cmake --build the cache + sync to both load locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the AICPU executor interface and improves code consistency through refactoring and renaming.
Changes
runtimeexecutor.cpp→aicpu_executor.cpp,RuntimeExecutor→AicpuExecutorruntimeCtxfromKernelArgsstructureg_executor→g_aicpu_executorfor better clarityFiles Changed
src/runtime/aicpu/runtimeexecutor.cpp→src/runtime/aicpu/aicpu_executor.cppsrc/platform/a2a3/aicpu/kernel.cppsrc/platform/a2a3/common/kernel_args.hsrc/platform/a2a3/host/devicerunner.cppexample/main.pyImpact