test: cover Windows encoded roots#54
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
hyfdev
force-pushed
the
agent/windows-encoded-root-matrix
branch
from
July 14, 2026 09:51
ad3a697 to
a6bb7a9
Compare
hyfdev
force-pushed
the
agent/windows-encoded-root-matrix
branch
from
July 14, 2026 13:56
a6bb7a9 to
31ed4cc
Compare
hyfdev
marked this pull request as ready for review
July 14, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The matrix first verifies the expected
std::path::Prefixvariant so a malformed fixture cannot silently exercise an ordinary component. Drive and verbatim-drive identifiers are intentionally excluded because Rust recognizes only ASCII alphabetic drive letters; a non-ASCII or surrogate pseudo-drive would not enter the drive-prefix comparator.Same-root invalid-encoding results assert exact wide output without requiring
Cow::Borrowed: non-UTF performance is not an optimization gate. Different-root results remain required to return the documented owned normalized target.This PR adds one Windows-only integration test file. It does not change production code, dependencies, benchmarks, or benchmark inputs.
Validation
SUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=0 cargo +1.97.0 test --locked -p sugar_pathSUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=1 cargo +1.97.0 test --locked --workspace --all-featurescargo +1.97.0 fmt --all -- --checkcargo +1.97.0 clippy --locked --workspace --all-targets --all-features -- -D warningsx86_64-pc-windows-msvcAt the rebased head
31ed4cc, all eight repository Actions jobs and external CodSpeed Analysis pass. Nativex86_64-pc-windows-msvcexecutes both encoded-root tests successfully under default and all features.