Skip to content

test: cover Windows invalid drive paths#66

Merged
hyfdev merged 1 commit into
mainfrom
agent/test-windows-invalid-drive
Jul 15, 2026
Merged

test: cover Windows invalid drive paths#66
hyfdev merged 1 commit into
mainfrom
agent/test-windows-invalid-drive

Conversation

@hyfdev

@hyfdev hyfdev commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • cover exact invalid-wide component comparison in Windows drive-relative paths
  • verify equal invalid components cancel while distinct components with the same lossy rendering remain distinct
  • preserve invalid-wide components when a drive-relative path is resolved against borrowed or owned explicit cwd

Why

The existing Windows invalid-encoding matrix covered unprefixed lexical, absolute, and root-relative paths, but not drive-relative helpers.

Three controlled errors survived the existing suite: comparing drive-relative components through lossy Unicode, refusing to compare any invalid-wide components, and dropping an invalid component while resolving a drive-relative path. The new raw UTF-16 assertions distinguish all three cases through the public APIs.

Validation

  • direct rustc --target x86_64-pc-windows-msvc --test ... --emit=metadata -D warnings cross-compilation against the built Windows library
  • default and cached invalid-encoding suites on the local Unix host
  • cargo fmt --all --check and git diff --check
  • two adversarial review rounds; the first found the missing equal-invalid control row, and the final round passed after it was added

Native Windows execution is provided by the existing GitHub Actions Windows job.

@hyfdev
hyfdev force-pushed the agent/test-windows-invalid-drive branch 3 times, most recently from d46f32d to 5982447 Compare July 15, 2026 09:16
@hyfdev
hyfdev force-pushed the agent/test-windows-invalid-drive branch from 5982447 to 1e3835f Compare July 15, 2026 09:24
@hyfdev
hyfdev marked this pull request as ready for review July 15, 2026 09:31
Copilot AI review requested due to automatic review settings July 15, 2026 09:31
@hyfdev
hyfdev merged commit 2c2b185 into main Jul 15, 2026
7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot mentioned this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants