fix: preserve borrowing for Windows drive-relative paths#67
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
hyfdev
marked this pull request as ready for review
July 15, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeandinto_normalizedsemanticsCowownership, borrow source, and consuming resultsC:..\..Why
The existing classifier test compares the production classifier with the production normalizer. It protects output equality, but cannot independently validate public normalization semantics or detect an unnecessary allocation when both paths produce the same value.
The new model exposed a real classifier gap: the generic Windows scan treated the second
\..inC:..\..as requiring normalization. Drive-relative leading parents cannot be collapsed, so the normalizer rebuilt an identical path and returned an owned result.The classifier now recognizes canonical drive-relative leading-parent tails while still rejecting duplicate separators, current-directory components, trailing separators in strip mode, and parents that follow a normal component.
Impact
Cow::Borrowedinto_normalizedreuses the original owned buffer for those pathsValidation
cached_current_dirworkspace tests