test: cover unavailable cwd after successful lookup#70
Merged
Conversation
hyfdev
marked this pull request as ready for review
July 18, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cached_current_dirsnapshotPath,str, andStringfailures with the directcurrent_direrror, and prove explicit absolutization remains independent of ambient cwdWhy
Existing tests covered an unavailable cwd before the first successful lookup, retry after that failure, and cwd changes between valid directories. They did not detect a cached provider that re-read or revalidated the real cwd after a successful cache initialization.
A controlled mutation that calls
current_dir()on a cache hit survives the previous cwd tests but fails the new lifecycle test after the directory is removed.Impact
This is a test-only contract change. Production code, dependencies, benchmarks, and allocation baselines are unchanged.
Validation
cargo fmt --all --checkSUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=0 cargo test --locked -p sugar_pathSUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=1 cargo test --locked --workspace --all-featurescached_current_dirruns for all affected integration testscargo clippy --locked --workspace --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc --locked --workspace --all-features --no-deps