Fix scaled-clamping regression#7
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 72701ed): https://box-transform-example--pr7-clamped-scaling-fix-svqluy7b.web.app (expires Wed, 12 Apr 2023 18:04:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e763d07f5363f277ae076213618ea06ad108e080 |
…ons to fix scale-clamping regressions.
BirjuVachhani
force-pushed
the
clamped_scaling_fix
branch
from
f901669 to
5955c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a long-standing issue with scaling not properly tracking the cursor.
This was due to the clamping box not doing its calculations correctly when trying to contain the main box. The logic has now been corrected.