Skip to content

[ENH] experiments: uniform call signature and terminology#178

Merged
SimonBlanke merged 6 commits into
hyperactive-project:mainfrom
fkiraly:uniform-signature
Aug 25, 2025
Merged

[ENH] experiments: uniform call signature and terminology#178
SimonBlanke merged 6 commits into
hyperactive-project:mainfrom
fkiraly:uniform-signature

Conversation

@fkiraly

@fkiraly fkiraly commented Aug 24, 2025

Copy link
Copy Markdown
Collaborator

In BaseExperiment descendants, makes the following consistent:

  • __call__ signature is now __call__(params), instead of __call__(**params) - for consistency with evaluate and the expected function/callable interface
  • the second return of score and evaluate is now consistently called "metadata" (instead of add_info), as referred to in the docstrings

Minor additional changes:

  • removed some unused imports

@fkiraly fkiraly added the enhancement New feature or request label Aug 24, 2025
@fkiraly fkiraly added this to the v5.0 milestone Aug 24, 2025
@fkiraly fkiraly requested a review from SimonBlanke August 24, 2025 19:41
@SimonBlanke SimonBlanke merged commit d88cf70 into hyperactive-project:main Aug 25, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants