This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Simplify function of checking OS init system#2
Closed
imdjh wants to merge 14 commits into
Closed
Conversation
added 13 commits
October 8, 2015 14:44
Renamed this function to check_initsystem for better explanation via its own name. Remove useless logic.
imdjh
pushed a commit
to imdjh/hyper-installer
that referenced
this pull request
Oct 8, 2015
I have notice that `show_message error` has always comes with an exit, so I merge the exit func into show_message.
You can use it with `show_message error ${ERR_TWO_ELEMENT_ARRAY[@]}`
I have noticed that the original implement on display_message always comesafter an error message. Since it's not the case user can easily solve themself, why not implement a fatal message and it would give the (almost) same result.
You can use it with `show_message fatal ${ERR_EXIT_CODE}`
Also fixed some typo and missleading message in this commit.
Install from remote -> Start fetching hyper package
Installing -> Installing hyper and hyperd
Since __done__ is a reserve keyword in bash, I personally recommand remove it(as I did).
Contributor
Author
|
I have a new PR, this is pretty old and not useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed this function to check_initsystem for better explanation via its own name.
Remove useless logic.