Add String and &String convert for PathAndQuery - #450
Merged
Conversation
When building a URI, it is not possible to provide neither String nor &String, which is useful when adding a path_and_query from a string built using format!. This commit adds implementation of From<String> and From<&String> for PathAndQuery.
Contributor
Author
|
Unsure about the procedure for contributing a patch. Please advise. |
Merged
BenxiangGe
pushed a commit
to BenxiangGe/http
that referenced
this pull request
Jul 26, 2021
When building a URI, it is not possible to provide neither String nor &String, which is useful when adding a path_and_query from a string built using format!. This commit adds implementation of From<String> and From<&String> for PathAndQuery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a URI, it is not possible to provide neither String nor
&String, which is useful when adding a path_and_query from a string
built using format!.
This commit adds implementation of From and From<&String> for
PathAndQuery.