Skip to content

Advertise full node name (with suffix) to DX#942

Merged
awrichar merged 3 commits intohyperledger:mainfrom
kaleido-io:dxdestination
Aug 10, 2022
Merged

Advertise full node name (with suffix) to DX#942
awrichar merged 3 commits intohyperledger:mainfrom
kaleido-io:dxdestination

Conversation

@awrichar
Copy link
Copy Markdown
Contributor

@awrichar awrichar commented Aug 8, 2022

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #942 (797da9f) into main (e22d84a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.02%     
==========================================
  Files         299      299              
  Lines       19478    19481       +3     
==========================================
+ Hits        19475    19476       +1     
- Misses          3        4       +1     
- Partials        0        1       +1     
Impacted Files Coverage Δ
internal/dataexchange/ffdx/ffdx.go 100.00% <100.00%> (ø)
internal/tokens/fftokens/fftokens.go 99.53% <0.00%> (-0.47%) ⬇️
internal/events/aggregator.go 100.00% <0.00%> (ø)
internal/namespace/manager.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@awrichar
Copy link
Copy Markdown
Contributor Author

awrichar commented Aug 9, 2022

This is failing because the DX node doesn't trust its own cert (when sending messages to itself).

Copy link
Copy Markdown
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit bd53159 into hyperledger:main Aug 10, 2022
@awrichar awrichar deleted the dxdestination branch August 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants