chore(examples): Fix hypervisor annotation and use bunny - #113
Open
cmainas wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the helloworld-c urunc packaging example to match the renamed hypervisor identifier (hyperlight-unikraft) and to rely on Bunny/BuildKit-driven image metadata rather than a standalone urunc.json file.
Changes:
- Update
urunc.Dockerfileto setcom.urunc.unikernel.hypervisor=hyperlight-unikraft, removeurunc.jsonusage, and source the kernel from the published GHCR kernel image. - Delete
examples/helloworld-c/urunc.json(annotations now expressed via image labels). - Update the
urunc-imageJust recipe to enable BuildKit for the urunc image build.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/helloworld-c/urunc.json | Removes the standalone urunc annotation JSON (no longer copied into the image). |
| examples/helloworld-c/urunc.Dockerfile | Switches to Bunny frontend, pulls the kernel from GHCR, and updates the hypervisor label to hyperlight-unikraft. |
| examples/helloworld-c/Justfile | Enables BuildKit specifically for urunc-image builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,15 +1,17 @@ | |||
| #syntax=harbor.nbfc.io/nubificus/bunny:latest | |||
Author
There was a problem hiding this comment.
A note one that. This is intentional; the annotations in urunc are not stable yet and they might change. We keep bunny up-to-date with the changes in urunc, so it is the easiest way to keep track of such changes.
Comment on lines
+49
to
+51
| # Build urunc-compatible OCI image (requires kernel to be built first) | ||
| urunc-image: build | ||
| docker build --platform linux/amd64 -f urunc.Dockerfile -t hello-hyperlight-unikraft:latest . | ||
| urunc-image: | ||
| DOCKER_BUILDKIT=1 docker build --platform linux/amd64 -f urunc.Dockerfile -t hello-hyperlight-unikraft:latest . |
cmainas
force-pushed
the
chore/urunc_Dockerfile
branch
from
August 6, 2026 16:19
52f2f08 to
9cbc640
Compare
Use [bunny](https://github.com/nubificus/bunny) to directly append the annotations in the image, instead of "urunc.json" file. Also update the urunc.Dockerfile, since the "hypervisor" name of hyperlight was changed to hyperlight-unikraft. Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the urunc.Dockerfile, since the "hypervisor" name of "hyperlight" was changed to "hyperlight-unikraft".
Also, replace the "urunc.json" file with direct use of bunny. However bunny requires
DOCKER_BUILDKIT=1. Not really sure why is set to 0, but if buildkit must remain disabled, I will bring back the "urunc.json" file.Fixes #112