Skip to content

Closes #1076: Code refactor to set trace context in run_vcpu function. #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vshailesh wants to merge 1 commit into from
Closed

Closes #1076: Code refactor to set trace context in run_vcpu function. #1181

vshailesh wants to merge 1 commit into from

Conversation

@vshailesh
Copy link
Contributor

@vshailesh vshailesh commented Jan 21, 2026

  • Small change to set up the guest trace context function call inside the run_vcpu function instead, to prevent any human error in future code changes.

@jsturtevant jsturtevant added the kind/bugfix For PRs that fix bugs label Jan 21, 2026
@ludfjig
Copy link
Contributor

ludfjig commented Jan 21, 2026

Thanks a lot for this! Looks like CI wants you to run a just fmt-apply, and a variable seems to be unused unless tracing feature is turned on. I would probably just name this parameter _tc so clippy doesn't complain about it if it's unused.

@vshailesh
Closes hyperlight-dev#1076: Code refactor to set trace context in run…
06c7c7a 
…_vcpu function.

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>
@vshailesh
Copy link
Contributor Author

vshailesh commented Jan 21, 2026

pushed again, completely forgot about clippy checks.

@vshailesh
Copy link
Contributor Author

vshailesh commented Jan 21, 2026

retracting this PR.

@vshailesh vshailesh closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees

No one assigned

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vshailesh @ludfjig @jsturtevant