Take guestbinary by ref instead of value - #560
Closed
ludfjig wants to merge 1 commit into
Closed
Conversation
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
June 3, 2025 23:33
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
June 3, 2025 23:51
af96a45 to
6698c2e
Compare
ludfjig
added
the
kind/enhancement
jprendes
reviewed
Jun 4, 2025
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
from
June 4, 2025 17:52
6698c2e to
fc417d0
Compare
danbugs
previously approved these changes
Jun 4, 2025
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
3 times, most recently
from
June 9, 2025 17:41
1b28b07 to
8ca12fc
Compare
jprendes
previously approved these changes
Jun 9, 2025
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
6 times, most recently
from
June 9, 2025 23:55
94b2b19 to
02befa1
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
2 times, most recently
from
June 10, 2025 00:34
8692e1a to
6d8caed
Compare
ludfjig
force-pushed
the
take_guestbinary_by_ref
branch
2 times, most recently
from
June 10, 2025 17:59
f17d33d to
5174202
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #559
Making
Uninitialized::newtake aGuestBinaryby ref instead of value is more flexible, allowing reuse of the same guest binary across many different sandboxes. This PR allows passing either a ref or value, to be maximally flexible and not be a breaking change