Fix url encoder by specifying allowed characters

[onmyway133]

• Xcode 9 changes url encoding https://stackoverflow.com/questions/44754996/is-addingpercentencoding-broken-in-xcode-9-beta-2
• This specifies allowed characters when encoding, usually this is our delimiter
• Add Utilities to do encoding. Also covered by tests 😎 . Run on Xcode 8 and Xcode 9
• Also, remove open(url) methods, as they are internal now
• Changes to Navigator will come in next PRs

[JohnSundell]

Nice fix 👍 Some comments inline, let me know what you think 🙂

[JohnSundell]

How come this is needed, since you have only removed code from this file?

[onmyway133]

Good catch. I added it by mistake. Will remove it

[JohnSundell]

I would suggest using a different name than Utilities (which is both very ambiguous, and tends to be a "catch all" for all kinds of unrelated APIs). Since these utilities are all about encoding strings, how about implementing them in an extension on String?

[onmyway133]

Ironically 😛 I just moved those from string extensions to a new class. I had some problem before when some frameworks have the same method on String

[JohnSundell]

Yeah, that's a valid point. In that case, how about a StringEncoder class or something like that?

[onmyway133]

Yeah, I can add that

[JohnSundell]

Document parameter allowed

[JohnSundell]

Also I'd name that parameter allowedCharacters, since just allowed is a bit ambiguous in this context.

[JohnSundell]

Also why not just pass a CharacterSet, just like to String?

[onmyway133]

You're right, I will add that