Potential fix for code scanning alert no. 2: Implicit narrowing conversion in compound assignment#7
Merged
hyperpostulate merged 1 commit intomasterfrom Jan 4, 2026
Merged
Conversation
…rsion in compound assignment Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/hyperpostulate/visual-novel-engine/security/code-scanning/2
In general, to fix implicit narrowing in compound assignments you ensure that both operands have compatible types, either by widening the destination or by making the right-hand side expression match the destination type (without relying on implicit narrowing).
In this specific case, the constraints are stored as
Float, and the accumulatorrelativeTotalis also afloat. The problematic line usesconstraint.doubleValue(), which promotes the value todoubleand then implicitly narrows back tofloatin the+=operation. The safest, behavior-preserving fix is to use thefloatrepresentation directly: callconstraint.floatValue()instead ofdoubleValue(). That way, the addition is performed infloatwithout an implicit narrowing cast, and the effective precision is unchanged because the source data is already aFloat.Concretely:
src/main/java/org/mesutormanli/visualnovel/engine/util/RelativeLayout.java, insidelayoutContainerHorizontally, change line 418 fromrelativeTotal += constraint.doubleValue();torelativeTotal += constraint.floatValue();.Float.Suggested fixes powered by Copilot Autofix. Review carefully before merging.