feat(cosmos): propagate $chain.env when calling scripts#703
Merged
Anmol1696 merged 5 commits intohyperweb-io:v1from Jun 22, 2025
Merged
feat(cosmos): propagate $chain.env when calling scripts#703Anmol1696 merged 5 commits intohyperweb-io:v1from
$chain.env when calling scripts#703Anmol1696 merged 5 commits intohyperweb-io:v1from
Conversation
michaelfig
force-pushed
the
mfig/propagate-chain-env
branch
from
6799b0b to
902090e
Compare
Collaborator
|
Awesome work, we need to change the base of the branch to Once merged into v1, i will make it portable to v2 |
michaelfig
force-pushed
the
mfig/propagate-chain-env
branch
from
ae2e1ef to
5043725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows parameterisation of a
config.yaml's 'chain[*].scripts', by passingchain[*].envenvironment variables wherever those scripts are invoked. This apparently already worked for$CHAIN_ID, but not for any other of the config.yaml's environment variables. There may be an even simpler way to accomplish it, so I am happy for any feedback you can suggest, @Anmol1696.Before this change, some scripts that we override (
update-config.shfor our particular use in Agoric/agoric-sdk#11502) would have to be manually copied-and-pasted with modifications, or generated from a template in order to have different behaviour when used in differentconfig.yamlfiles but also with the same$CHAIN_ID.Credit to @Muneeb147 for intuitively attempting to use
chain.envfor this purpose, and being (rightfully!) surprised that it wasn't applied when running our customupdate-config.sh.