add useQueryClientResolver to rpc client

[Zetazzz]

No description provided.

[turadg]

should still be const, right?

Suggested change

	let client = queryClientResolver ? await queryClientResolver(rpcEndpoint) : await createConnectCometQueryClient(rpcEndpoint);
	const makeClient = queryClientResolver || createConnectCometQueryClient;
	const client = await makeClient(rpcEndpoint);

[turadg]

isn't this optional?

Suggested change

	queryClientResolver: (rpcEndpoint: string | HttpEndpoint) => Promise<QueryClient>;
	queryClientResolver?: (rpcEndpoint: string | HttpEndpoint) => Promise<QueryClient>;

"resolver" is a little confusing to me. This makes a client. Consider treating the current behavior as the an explicit default:

Suggested change

	queryClientResolver: (rpcEndpoint: string | HttpEndpoint) => Promise<QueryClient>;
	makeClient?: (rpcEndpoint: string | HttpEndpoint) => Promise<QueryClient> = createConnectCometQueryClient;

[turadg]

why is this change necessary?

[Zetazzz]

Please excuse me, I think I need to keep this as the default values for makeClient

[turadg]

does this need to be a codegen option? couldn't the code just allow it always as an optional param?

[Zetazzz]

I believe we have to do it for people who don't want generate this code.

[turadg]

is this change intentional? seems unrelated to the PR

[Zetazzz]

It's a minor fix for other purpose, never mind about this.

[turadg]

Higher level… I see this is the status quo:

export const createRPCQueryClient = async ({
  rpcEndpoint
}: {
  rpcEndpoint: string | HttpEndpoint;
}) => {
  const tmClient = await connectComet(rpcEndpoint);
  const client = new QueryClient(tmClient);

What I'd really like is for createRPCQueryClient to do less. It shouldn't even need to import connectComet, imo. That alone pulls in Axios which is quite opinionated.

What I'd really like to see is for createRPCQueryClient to itself take the Tendermint34Client value that needs to be passed to the QueryClient constructor. In some other module you could have a convenience factory that takes an HttpEndpoint and chooses an HTTP client but this module should prescribe the query transport.

Would that be feasible? Then you wouldn't need a config option that complicates your docs, testing and maintenance. It's just a more flexible factoring.

[Zetazzz]

I don't why this's merged, I didn't press any button yet, strange.
No worry, I'll open another to do the fix

[Zetazzz]

Higher level… I see this is the status quo:

export const createRPCQueryClient = async ({
  rpcEndpoint
}: {
  rpcEndpoint: string | HttpEndpoint;
}) => {
  const tmClient = await connectComet(rpcEndpoint);
  const client = new QueryClient(tmClient);

What I'd really like is for createRPCQueryClient to do less. It shouldn't even need to import connectComet, imo. That alone pulls in Axios which is quite opinionated.

What I'd really like to see is for createRPCQueryClient to itself take the Tendermint34Client value that needs to be passed to the QueryClient constructor. In some other module you could have a convenience factory that takes an HttpEndpoint and chooses an HTTP client but this module should prescribe the query transport.

Would that be feasible? Then you wouldn't need a config option that complicates your docs, testing and maintenance. It's just a more flexible factoring.

Thank you very much for you review, we'll have a better way to handle this after some higher priority issues are handled.