Skip to content

GitHub webhooks: be tolerant - #341

Merged
danielbeardsley merged 2 commits into
masterfrom
github-webhooks--be-tolerant
Nov 4, 2022
Merged

GitHub webhooks: be tolerant#341
danielbeardsley merged 2 commits into
masterfrom
github-webhooks--be-tolerant

Conversation

@danielbeardsley

@danielbeardsley danielbeardsley commented Nov 4, 2022

Copy link
Copy Markdown
Member
  • Gracefully deal with null pull.body
  • Support parsing larger webhook bodies (we've see pretty big ones)

qa_req 0 - I think there's not much to QA here without actually trying it

Sometimes body is null if a pull is created with no description it
seems.
I swear we did this before... but I must be remembering

Sometimes, webhook bodies are bigger than 100kb (the default limit).
Let's bump that to 1MB.

@andyg0808 andyg0808 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@danielbeardsley
danielbeardsley merged commit 781ea47 into master Nov 4, 2022
@danielbeardsley
danielbeardsley deleted the github-webhooks--be-tolerant branch November 4, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants