Add a check for when there isn't a trackerHitRelationCollection#147
Merged
Conversation
jmcarcell
changed the title
Contributor
Author
|
I couldn't reproduce the crash but this is better than having it crashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
A crash came up in the FCC Full Sim meeting: https://indico.cern.ch/event/1676587/contributions/7055559/attachments/3265903/5832831/FCC_Full-SIMMeeting_29_04_26.pdf
Having a look at the stack trace (backup of the slides), it could be a dereference of a nullptr, and this is the only collection that is not being checked. So this may be a good improvement by itself.
@jessy-daniel, do you think this could be the fix? (what does your digitizer change in terms of output collections compared to DDPlanarDigi?) You could test it locally by building this package, then running
k4_local_repoif you are using the stack. We also have a debug build if you pass-dwhen sourcing the setup script in the stack. It will be much slower, but if it crashes it will give us the line number in the file.