fix(conversation): unify provider/model resolution across send/cron paths (ELECTRON-1HX, ELECTRON-1HM)#326
Open
TCP404 wants to merge 1 commit into
Open
fix(conversation): unify provider/model resolution across send/cron paths (ELECTRON-1HX, ELECTRON-1HM)#326TCP404 wants to merge 1 commit into
TCP404 wants to merge 1 commit into
Conversation
…aths (ELECTRON-1HX, ELECTRON-1HM) Extract provider_model_from_conversation_row() so interactive send_message and cron JobExecutor share one resolver, preventing cron jobs from picking up provider/model values that diverge from the conversation row. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
TCP404
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_messageand the cronJobExecutoreach had their own provider/model resolver. For some conversation row states the cron path produced a different provider/model than the user-facing path, leading to panics or surfaced errors.crates/aionui-conversation/src/task_options.rs(195 new lines) exposingprovider_model_from_conversation_row(), used by both call sites.Test plan
cargo test -p aionui-conversationcargo test -p aionui-cronjust build -fGenerated with Claude Code