Improvement/234 create main evaluation script#243
Open
dkkdark wants to merge 46 commits into
Open
Conversation
added 30 commits
February 17, 2026 15:13
…tps://github.com/iai-group/UserSimCRS into improvement/233-create-classes-for-metrics
…tps://github.com/iai-group/UserSimCRS into improvement/233-create-classes-for-metrics
added 13 commits
March 10, 2026 17:10
…mprovement/233-create-classes-for-metrics
…://github.com/iai-group/UserSimCRS into improvement/234-create-main-evaluation-script
…github.com/iai-group/UserSimCRS into improvement/234-create-main-evaluation-script
|
NoB0
reviewed
Apr 13, 2026
dkkdark
commented
Apr 14, 2026
| annotate_dialogues(dialogues, user_nlu, agent_nlu) | ||
|
|
||
|
|
||
| def get_summary_by_agent( |
Collaborator
Author
There was a problem hiding this comment.
We can’t skip calling it when there is only one agent because we won’t get a summary for it
dkkdark
commented
Apr 14, 2026
NoB0
reviewed
Apr 21, 2026
NoB0
left a comment
NoB0
left a comment
Collaborator
There was a problem hiding this comment.
Some points need to be clarified
NoB0
approved these changes
May 4, 2026
NoB0
left a comment
NoB0
left a comment
Collaborator
There was a problem hiding this comment.
For now LGTM (please check comments on confuse key access). Although, a follow-up should be created to investigate if build_metric_registry and evaluate_metric can be optimized with regards to maintenance when new metrics are supported.
| ) | ||
|
|
||
| if config["annotate_dialogues"].get(): | ||
| if not config["user_nlu"].get(None): |
Collaborator
There was a problem hiding this comment.
The get in confuse behaves bit differently than the get for a dictionary, i.e., it expects a template. I would suggest to look at the documentation, but I think that simply checking if the key is in the configuration and is not empty should work.
| raise ValueError( | ||
| "`user_nlu` is required when `annotate_dialogues` is True." | ||
| ) | ||
| if not config["agent_nlu"].get(None): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.