Merged
Conversation
|
Preview of modified Markdown: |
vidarl
requested changes
Feb 25, 2025
Co-authored-by: Vidar Langseid <vl@ibexa.co>
mnocon
approved these changes
Feb 25, 2025
Contributor
mnocon
left a comment
mnocon
left a comment
There was a problem hiding this comment.
Thank you Thorsten!
Looks good to me doc-wise, I assume you've tested this already? Or do you think QA is needed here?
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Contributor
Author
It's tested - @vidarl and myself did a quick" testing session" |
Contributor
|
Ok, so just ping me when you feel like it's ready to be merged and I will take care of that 😉 |
vidarl
approved these changes
Feb 25, 2025
Contributor
Author
@mnocon , can be merged, I am feeling it ! |
mnocon
added a commit
that referenced
this pull request
Feb 25, 2025
* Fixed basic auth snippet * Update docs/infrastructure_and_maintenance/cache/http_cache/fastly.md Co-authored-by: Vidar Langseid <vl@ibexa.co> * Update docs/infrastructure_and_maintenance/cache/http_cache/fastly.md Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> --------- Co-authored-by: Vidar Langseid <vl@ibexa.co> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Feb 25, 2025
* Fixed basic auth snippet * Update docs/infrastructure_and_maintenance/cache/http_cache/fastly.md Co-authored-by: Vidar Langseid <vl@ibexa.co> * Update docs/infrastructure_and_maintenance/cache/http_cache/fastly.md Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> --------- Co-authored-by: Vidar Langseid <vl@ibexa.co> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the steps from https://doc.ibexa.co/en/latest/infrastructure_and_maintenance/cache/http_cache/fastly/#enable-basic-auth-on-fastly we noticed that the 1st ESI request is never cached when enabling Basic Auth.
PR removes
req.http.Authorizationheader for all ESI subrequests - fixing the issue.