Conversation
Preview of modified filesPreview of modified Markdown: |
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
e91a23b to
f263746
Compare
f263746 to
6463dd5
Compare
micszo
left a comment
There was a problem hiding this comment.
Thanks for covering the alternative!
| ``` | ||
|
|
||
| For more information and a list of available choices, see [Connection pool](https://www.elastic.co/guide/en/elasticsearch/client/php-api/7.x/connection_pool.html). | ||
| For more information and a list of available choices, see [Node pool](https://www.elastic.co/docs/reference/elasticsearch/clients/php/node_pool). |
There was a problem hiding this comment.
Shouldn't we put the link to 7x and 8x clients here?
julitafalcondusza
left a comment
There was a problem hiding this comment.
Please check my comments.
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
| The node pool manages the list of active nodes, which can change over time due to connectivity issues, host malfunction, or when you add new nodes to the cluster to increase performance. | ||
|
|
||
| You can change the default setting with the following key: | ||
| By default, Elasticsearch 8 uses `SimpleNodePool` with `RoundRobin` selector and `NoResurrect` strategy. |
There was a problem hiding this comment.
I'd put it differently, because users can opt for either of the supported versions. Something along the lines of:
"In installations running Elasticsearch 8.18+, the default configuration uses SimpleNodePool with a RoundRobin selector and a NoResurrect strategy."
At the same time, I wouldn't remove information that discusses 7.16.2+ configuration, but have both.
Unless of course we want to adamantly say "you must use elastic 8" or at least "Ibexa strongly recommends that you use elastic 8" in all those places where two versions are mentioned, followed by "for 7.16.2+ configuration, refer to our documentation for the v.4.6.x release" (in requirements and a note in install elasticsearch)
There was a problem hiding this comment.
Even if you decide to use Elasticsearch 7 (which we won't recommend anymore), you cannot use the existing configuration - please see the update instructions, the old configuration is deprecated and does nothing.
Regardless of Elasticsearch version, you have to use the "node pool" settings - even when staying on Elasticsearch 7
docs/search/search_engines/elasticsearch/configure_elasticsearch.md
Outdated
Show resolved
Hide resolved
…ch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
* Added Redis 8+ and Valkey 9+ support (#2996) * Added Redis 8+, 9+ and Valkey 9+ support * Removed Redis 9 * Update docs/getting_started/requirements.md * Apply suggestions from code review * Added mention about messenger tables (#3003) * Removed warning about Safari * Elasticsearch 8 support (#3002) * Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Improved wording --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Mention that the new configuration is for both ES 7 and 8 (#3013) * PHP API Ref HTML * REST API Ref HTML * Release notes for 5.0.5 (#3011) * Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Release notes for 5.0.5 * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Removed broken links * Removed broken fragment * Bumped mkdocs variable * Fixed image * Removed big TODO headers * Fixes * Adjusted headers * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Added links to REST API ref --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: ibexa-workflow-automation-1[bot] <ibexa-workflow-automation-1[bot]@users.noreply.github.com>
* Added Redis 8+ and Valkey 9+ support (#2996) * Added Redis 8+, 9+ and Valkey 9+ support * Removed Redis 9 * Update docs/getting_started/requirements.md * Apply suggestions from code review * Added mention about messenger tables (#3003) * Removed warning about Safari * Elasticsearch 8 support (#3002) * Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Improved wording --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Mention that the new configuration is for both ES 7 and 8 (#3013) * PHP API Ref HTML * REST API Ref HTML * Release notes for 5.0.5 (#3011) * Adjusted the doc * Selfreview * Apply suggestion from @mnocon * Reworked the doc: api_key examples and ES7 is still supported * Apply suggestions from Doc review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Release notes for 5.0.5 * Added suggestion that updating is recommended - and removed explicit version * Update docs/search/search_engines/elasticsearch/configure_elasticsearch.md Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Removed broken links * Removed broken fragment * Bumped mkdocs variable * Fixed image * Removed big TODO headers * Fixes * Adjusted headers * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> * Added links to REST API ref --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com> Co-authored-by: ibexa-workflow-automation-1[bot] <ibexa-workflow-automation-1[bot]@users.noreply.github.com>
Doc for https://github.com/ibexa/elasticsearch/pull/70
Target: v5 only