Skip to content

Remove IServiceProvider#753

Merged
minichma merged 1 commit into
mainfrom
work/minichma/feature/remove_serviceprovider
Mar 10, 2025
Merged

Remove IServiceProvider#753
minichma merged 1 commit into
mainfrom
work/minichma/feature/remove_serviceprovider

Conversation

@minichma
Copy link
Copy Markdown
Collaborator

@minichma minichma commented Mar 10, 2025

The concept of the IServiceProvider seems overly complex and makes reasoning on the actual control flow hard. It is used for managing IEvaluator instances and for serialization. Remove the use for IEvaluator for now, which already allows removing it from the model types. Keep it for serialization for now and remove it in a subsequent PR.

@minichma minichma closed this Mar 10, 2025
@minichma minichma deleted the work/minichma/feature/remove_serviceprovider branch March 10, 2025 19:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Ical.Net/CalendarComponents/Journal.cs 0% 1 Missing ⚠️
Ical.Net/CalendarComponents/RecurringComponent.cs 50% 1 Missing ⚠️
Ical.Net/VTimeZoneInfo.cs 0% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (70%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (66%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #753   +/-   ##
===================================
- Coverage    66%    66%   -0%     
===================================
  Files       104    104           
  Lines      4617   4590   -27     
  Branches   1147   1144    -3     
===================================
- Hits       3055   3034   -21     
+ Misses     1129   1124    -5     
+ Partials    433    432    -1     
Files with missing lines Coverage Δ
Ical.Net/CalendarComponents/CalendarEvent.cs 75% <100%> (ø)
Ical.Net/CalendarComponents/Todo.cs 66% <100%> (ø)
Ical.Net/CalendarObject.cs 63% <ø> (+3%) ⬆️
Ical.Net/DataTypes/CalendarDataType.cs 46% <ø> (+2%) ⬆️
Ical.Net/DataTypes/RecurrencePattern.cs 74% <100%> (-<1%) ⬇️
Ical.Net/Evaluation/RecurrenceUtil.cs 94% <100%> (ø)
Ical.Net/Evaluation/RecurringEvaluator.cs 92% <100%> (-1%) ⬇️
...al.Net/Serialization/DataTypes/StringSerializer.cs 77% <ø> (-1%) ⬇️
Ical.Net/CalendarComponents/Journal.cs 60% <0%> (-4%) ⬇️
Ical.Net/CalendarComponents/RecurringComponent.cs 65% <50%> (-1%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@minichma minichma restored the work/minichma/feature/remove_serviceprovider branch March 10, 2025 19:59
@minichma minichma reopened this Mar 10, 2025
@minichma minichma force-pushed the work/minichma/feature/remove_serviceprovider branch from 9347735 to 19d7400 Compare March 10, 2025 20:04
@sonarqubecloud
Copy link
Copy Markdown

@minichma minichma marked this pull request as ready for review March 10, 2025 20:09
@minichma minichma requested a review from axunonb March 10, 2025 20:09
@minichma
Copy link
Copy Markdown
Collaborator Author

@axunonb This PR is a tiny step towards decoupling evaluation from the model, following the discussion in #749 (comment).

Copy link
Copy Markdown
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes reasoning on the actual control flow hard

Absolutely, love it!

@minichma minichma merged commit 64919b9 into main Mar 10, 2025
@minichma minichma deleted the work/minichma/feature/remove_serviceprovider branch March 10, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants