Remove IServiceProvider#753
Conversation
Codecov ReportAttention: Patch coverage is ❌ Your patch status has failed because the patch coverage (70%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #753 +/- ##
===================================
- Coverage 66% 66% -0%
===================================
Files 104 104
Lines 4617 4590 -27
Branches 1147 1144 -3
===================================
- Hits 3055 3034 -21
+ Misses 1129 1124 -5
+ Partials 433 432 -1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
9347735 to
19d7400
Compare
|
|
@axunonb This PR is a tiny step towards decoupling evaluation from the model, following the discussion in #749 (comment). |
axunonb
left a comment
There was a problem hiding this comment.
makes reasoning on the actual control flow hard
Absolutely, love it!



The concept of the
IServiceProviderseems overly complex and makes reasoning on the actual control flow hard. It is used for managingIEvaluatorinstances and for serialization. Remove the use forIEvaluatorfor now, which already allows removing it from the model types. Keep it for serialization for now and remove it in a subsequent PR.