Fix day_of_year#326
Closed
ordermuppet wants to merge 3 commits into
Closed
Conversation
| @@ -1,3 +1,5 @@ | |||
| before_install: | |||
| - gem update bundler | |||
Author
There was a problem hiding this comment.
Stole this from #321 - that build continued to fail because of an unrelated issue, addressed in this PR.
Collaborator
|
The first commit on this branch looks good at a glance: I can apply the bundler changes separately, and the last commit with the DST issue isn't valid. I guess this problem has gone unnoticed until this year because 2016 is a leap year, and a specific test for "Dec 31" as "-1" was untested for regular years before... can we add a test to verify both leap years and non-leap years? The scenario "every fourth year on new year's eve" from #277 seems like a worthwhile scenario to specify here. |
avit
added a commit
that referenced
this pull request
Mar 19, 2017
Collaborator
|
Merged in #381. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a simple fix - i.e.
day_of_year(-1)should refer to day 365 (in a non-leap year), but as written it'll result in 364 (-1 + 365, on line 34). This should fix #277.