Skip to content

Pdo, fixed sql error if emtpy filter #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mruz merged 2 commits into from
Dec 3, 2018
Merged

Pdo, fixed sql error if emtpy filter #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54fe21
Pdo, fixed sql error if emtpy filter
Dec 1, 2018
cc2942a
let
Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ice/db/driver/pdo.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,13 @@ class Pdo implements DbInterface
}

let filtered = this->where(filters),
sql .= columns . " FROM " . sprintf(this->identifier, from) . " WHERE " . filtered[0],
sql .= columns . " FROM " . sprintf(this->identifier, from),
values = filtered[1];

if !empty filtered[0] {
let sql .= " WHERE " . filtered[0];
}

if isset options["group"] {
if typeof options["group"] == "array" {
let sql .= " GROUP BY " . implode(", ", options["group"]);
Expand Down