Fix JSON highlighting - #418
Merged
Merged
Conversation
ltrzesniewski
force-pushed
the
fix-json
branch
from
December 18, 2023 09:59
a5b426f to
4689cf6
Compare
Closed
|
Any chance on this getting in? |
|
Thank you, Siegfried! 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing icsharpcode/ILSpy#3138 I noticed the JSON highlighting was wrong (see the last 2 lines in the screenshot), so this PR fixes that.
EDIT: I noticed there's an issue for this, so this fixes #410.
Here's the difference for the following example:
{ "String": "Value", "Bool": true, "Null": null, "Number:": -42e10, "Object": { "Foo:": "Bar", "Multiline Key" : "Value" }, "Array": ["Foo", "Bar", "Baz"] }Before:
After:
The rule for numbers adds support for
-and reformats the regex.I also kept the existing single-quoted strings and hex numbers which are not part of the JSON spec.