Skip to content

Introducing ILSpy.ReadyToRun - #1872

Merged
siegfriedpammer merged 20 commits into
icsharpcode:masterfrom
cshung:dev/andrewau/ready-to-run
Dec 31, 2019
Merged

Introducing ILSpy.ReadyToRun#1872
siegfriedpammer merged 20 commits into
icsharpcode:masterfrom
cshung:dev/andrewau/ready-to-run

Conversation

@cshung

@cshung cshung commented Dec 21, 2019

Copy link
Copy Markdown
Contributor

Fixes #1864

This PR introduces ILSpy.ReadyToRun, a plugin for disassembling pre-compiled methods contained in a ready-to-run image.

The code is the same as what I wrote before arranged as a plugin.

@christophwille

Comment thread ILSpy.ReadyToRun/ILSpy.ReadyToRun.csproj Outdated
Comment thread ILSpy.ReadyToRun/ILSpy.ReadyToRun.csproj
@christophwille

christophwille commented Dec 21, 2019

Copy link
Copy Markdown
Member

How about a fourth option - have the copy of the code for ILCompiler.Reflection.ReadyToRun.dll in a separate repository, and build an "xyz-branded" temporary NuGet from it that we can reference (until the official package arrives)?

Edit (because of time zone differences): yes, the intention would be that you "own" the copy in a repo of yours, and also publish that temp NuGet (can be obsoleted later) - that way you have full control over the changes & when you need them for your pull requests.

@cshung
cshung force-pushed the dev/andrewau/ready-to-run branch from 420d792 to 595ec17 Compare December 21, 2019 23:13
@cshung
cshung force-pushed the dev/andrewau/ready-to-run branch from 2e9d994 to e5866d3 Compare December 23, 2019 07:20
@cshung cshung changed the title [WIP] Introducing ILSpy.ReadyToRun Introducing ILSpy.ReadyToRun Dec 27, 2019
@cshung

cshung commented Dec 27, 2019

Copy link
Copy Markdown
Contributor Author

The changes look good to me, thanks!

Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
@siegfriedpammer

Copy link
Copy Markdown
Member

Are you planning on fixing/implementing all things marked TODO before merging?

@cshung

cshung commented Dec 29, 2019

Copy link
Copy Markdown
Contributor Author

Are you planning on fixing/implementing all things marked TODO before merging?

My hope is to merge in a minimally viable product first and then address the rest later. If you believe any of the TODOs should be addressed upfront, please let me know.

Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
Comment thread ILSpy.ReadyToRun/ReadyToRunLanguage.cs Outdated
Comment thread ILSpy/LoadedAssembly.cs Outdated
@siegfriedpammer

Copy link
Copy Markdown
Member

Thank you very much! LGTM

@siegfriedpammer
siegfriedpammer merged commit d8e42d9 into icsharpcode:master Dec 31, 2019
@cshung
cshung deleted the dev/andrewau/ready-to-run branch December 31, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadyToSpy

5 participants