Support for single-file bundle from .NET 6. - #2373
Merged
Merged
Conversation
This supports the new version and also the new compressed files.
Member
|
In case you missed the milestone being added - we will merge this PR once 7.0 is released. |
dgrunwald
reviewed
Apr 30, 2021
| { | ||
| throw new InvalidDataException($"Corrupted single-file entry '${entry.RelativePath}'. Declared decompressed size '${entry.Size}' is not the same as actual decompressed size '${decompressedStream.Length}'."); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Don't we have decompressedStream.Position == decompressedStream.Length at this point?
I think we need to seek back to the start before returning the stream.
Contributor
Author
There was a problem hiding this comment.
Good point - it somehow worked without it - but it should be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new version and also the new compressed files.
Reacts to .NET changes:
dotnet/runtime#49855
dotnet/runtime#50817