Add IFileLoader API - #3191
Merged
Merged
Conversation
siegfriedpammer
force-pushed
the
file-loaders
branch
from
March 31, 2024 09:25
fbbcff3 to
a814e02
Compare
dgrunwald
reviewed
Mar 31, 2024
|
|
||
| public interface IFileLoader | ||
| { | ||
| LoadResult? Load(string fileName, Stream stream, FileLoadSettings settings); |
Member
There was a problem hiding this comment.
Maybe this should be async? We're already calling it within an async method; so this would give loaders some additional implementation options.
siegfriedpammer
force-pushed
the
file-loaders
branch
from
March 31, 2024 16:46
a814e02 to
963ff7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.