Skip to content

Fix possible ObservableCollection re-entrance crash when trying to na…#3294

Merged
siegfriedpammer merged 1 commit into
icsharpcode:masterfrom
tom-englert:dev/WpfRefactoring
Sep 28, 2024
Merged

Fix possible ObservableCollection re-entrance crash when trying to na…#3294
siegfriedpammer merged 1 commit into
icsharpcode:masterfrom
tom-englert:dev/WpfRefactoring

Conversation

@tom-englert

Copy link
Copy Markdown
Contributor

…vigate to a collapsed item.

@siegfriedpammer
siegfriedpammer merged commit 64cbcd4 into icsharpcode:master Sep 28, 2024
@siegfriedpammer

Copy link
Copy Markdown
Member

Thank you very much!

@siegfriedpammer

Copy link
Copy Markdown
Member

Looking at ILSpy/AssemblyTree/AssemblyTreeModel.cs as a whole I see that we sometimes do a null check (or ?) on activeView and sometimes don't. Is this intentional?

@tom-englert

Copy link
Copy Markdown
Contributor Author

I think that should be always, I'm just not used to work without NRTs enabled 😔

@tom-englert

Copy link
Copy Markdown
Contributor Author

I'll fix this

@siegfriedpammer

siegfriedpammer commented Sep 28, 2024

Copy link
Copy Markdown
Member

you can enable NRT on any file you touch, if you think it makes work easier... however, please not all files at once... that will be a pain to review and there already is some work done in #3295 #3287 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants