Skip to content

Fix null reference exception when writing resource files - #3474

Merged
dgrunwald merged 1 commit into
icsharpcode:masterfrom
ds5678:fix-null-reference-exception-when-writing-resource-files
May 7, 2025
Merged

Fix null reference exception when writing resource files#3474
dgrunwald merged 1 commit into
icsharpcode:masterfrom
ds5678:fix-null-reference-exception-when-writing-resource-files

Conversation

@ds5678

@ds5678 ds5678 commented May 6, 2025

Copy link
Copy Markdown
Contributor

Problem

TryOpenStream can return null, and we previously didn't check for that.

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
    • It's similar to the null checks for miscellaneous files.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

@dgrunwald
dgrunwald merged commit 8e7e018 into icsharpcode:master May 7, 2025
@ds5678
ds5678 deleted the fix-null-reference-exception-when-writing-resource-files branch May 26, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants