Smaller Fixes for Avalonia Branch Merge - #3756
Merged
Merged
Conversation
Updated .NET SDK version requirements in README.
These three project settings were present in the WPF build but lost in the move to Avalonia. RollForward=major matters most: the default publish is framework-dependent (publish.ps1 uses --no-self-contained) and the app targets net10.0, so without it a machine that only has a newer major runtime installed fails to start the app. DynamicAdaptationMode (DATAS) lets server GC shrink its heap count to the live load for a smaller idle working set, and Debug-only CheckForOverflowUnderflow traps arithmetic wrap during development. Assisted-by: Claude:claude-opus-4-8:Claude Code
CaretHighlightAdornerTests waited on the wall clock (3s budget) for the adorner's 1s real-time DispatcherTimer to remove it. Avalonia.Headless has no simulated clock, so under a loaded CI runner the dispatcher-thread timer plus the poll loop slipped past the tight budget and the test timed out intermittently. Extract the teardown the lifetime timer runs into Dismiss(); the test grabs the live adorner and calls it directly, verifying the unregister half without any timing dependency. Registration is still exercised through the real OnReferenceClicked path, and production behaviour is unchanged. Assisted-by: Claude:claude-opus-4-8:Claude Code
Selecting a C# version, switching to a version-less language (IL), then back to C# left the toolbar's version ComboBox blank even though LanguageService had restored CurrentVersion. The MVVM-toolkit setter runs OnCurrentLanguageChanged (which assigns CurrentVersion, pushing it onto the bound SelectedItem) before it raises PropertyChanged for CurrentLanguage (which repopulates ItemsSource from the new language's versions). So SelectedItem is set against the previous language's still-stale, empty list, rejected, and never re-pulled once ItemsSource updates. Re-assert the version combo's SelectedItem from the bound CurrentVersion after each ItemsSource swap settles, keeping the model untouched. Assisted-by: Claude:claude-opus-4-8:Claude Code
Two Options tests selected the whole System.Linq.Enumerable type and then awaited WaitForDecompiledTextAsync. That decompile takes >15 s in headless and overran the 60 s wait on a loaded CI runner, so the suite flaked intermittently (green in one run of a commit, red in another). The behaviours under test -- that a re-decompile setting refreshes the active tab, and that the refresh does not steal focus from the Options tab -- fire on whatever the tab shows, so a single small method exercises them just as well and decompiles near-instantly. Assisted-by: Claude:claude-opus-4-8:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<RollForward>major</RollForward>forILSpy.exe#3391