Skip to content
This repository was archived by the owner on Oct 20, 2020. It is now read-only.

Updated build.gradle#152

Closed
Kouznetsov wants to merge 5 commits intoidehub:masterfrom
Kouznetsov:patch-1
Closed

Updated build.gradle#152
Kouznetsov wants to merge 5 commits intoidehub:masterfrom
Kouznetsov:patch-1

Conversation

@Kouznetsov
Copy link

  • Replaced compile by implementation
  • Updated the targetSdkVersion, buildToolsVersion compileSdkVersion default values to their latest versions.

- Replaced compile by implementation
- Updated the targetSdkVersion, buildToolsVersion compileSdkVersion default values to their latest versions.
Updated gradle version from 2.2.3 to 3.3.1 which currently is the default version supplied when initializing a fresh RN project.
Added google() repository for the new gradle version
@Kouznetsov
Copy link
Author

The CI fails to build the project properly because the sdkBuildTools 28.0.3 license has not been accepted. Isn't Travis supposed to automatically input a y in this case ?

@cbrevik
Copy link
Member

cbrevik commented May 1, 2019

Hi! Thanks for the PR.

The build is probably failing because build tools 28.0.3 has not been added as a component in the travis.yml file:

- build-tools-23.0.1

This is also a breaking change for older RN projects, so the example project also needs to be updated in order for the CI build to run through;

"react-native": "0.52.2",

Have you tested this change locally @Kouznetsov?

@stale
Copy link

stale bot commented Jun 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 30, 2019
@stale stale bot closed this Jul 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants