Improved Callback and Error Handling

[austinkettner]

@idehub here are the edits we made for improved and proper handling with in-app-billing-v3

Related and resolves #85

[cbrevik]

I'll review this PR in more detail later. But please do not manually update the version number in PR.

[austinkettner]

Why is this? As part of these changes we expect the version to be incremented. It doesn't make sense for us to downgrade this as we increment it for proper cache/references in lockfiles.

[cbrevik]

What you do for forks is not up to me. But for upstream, i.e. this repository, I want to increment the version myself. This is because I might add other changes along with this version.

[austinkettner]

Makes sense! Thanks @cbrevik -- we will update this.

[austinkettner]

Ok, reverted to 2.4.0, you can do a squash now. We are ok with this being merged =) @cbrevik

[cbrevik]

Cool, I'll look into this tomorrow! Has the code been tested by you in your app(s)?

[austinkettner]

Yep we have used it in our apps and through that testing is how we resolved the various callback issues.

[kawashimaken]

It will be great to see this pull request to be merged soon! 😃

[npinochet]

I'd tried this pull request, but I'm still getting no callbacks from some functions like InAppBilling.getProductDetailsArray. It appears this fix doesn't solve the problem.

[freiserg]

After this PR 'purchase' doesn't return transactionDetails. It returns 'true'.

[kristfal]

@freiserg I have the same issue.

This PR breaks the current functionality of the lib and should be marked as a breaking change with the associated readme updates.

A current workaround is:

Purchase -> loadOwnedPurchases -> listOwnedSubscriptions / products -> validate each receipt

[cbrevik]

I'll look into this. Resolving with true is obviously a bug.

[cbrevik]

I've reverted this PR, and added a new function.
Call InAppBilling.shortCircuitPurchaseFlow(true) to short circuit the normal purchase flow and return true as in this PR if purchase seems to have gone successfully. This is for the people having problems with no callbacks, and want the functionality of this PR.

I'd recommend re-testing with the newest version of this lib (2.6.0) though. I've updated the dependent version of the underlying lib, and they have some changes around handleActivityResult.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.