This repository was archived by the owner on Oct 20, 2020. It is now read-only.
Make sure to call BillingProcessor::handleActivityResult()#95
Closed
wasedaigo wants to merge 1 commit intoidehub:masterfrom
Closed
Make sure to call BillingProcessor::handleActivityResult()#95wasedaigo wants to merge 1 commit intoidehub:masterfrom
wasedaigo wants to merge 1 commit intoidehub:masterfrom
Conversation
Member
|
Thanks for this PR; but I've tried to fix it in another way. Can you re-test with |
Author
|
@cbrevik Ok, I will give a try tomorrow. Please wait. |
Author
|
Confirmed your fix is working |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that this library never calls BillingProcessor::handleActivityResult(). It seems calling this method is absolutely necessary, but I could not find anywhere in the codebase calling.
handleActivityResult() does important things such as calling onProductPurchased, reportBillingError(), write purchaseData to the cache, so not calling this is critical.
This PR fixed the following problems for me:
true, but the second purchase returns transactionDetailsI think there is a good chance I am misunderstanding something, in that case please let me know what I am doing wrong. At least it is true that I was having the issue 1&2.
I am using
react-native 0.52.0&react-native-billing: 2.5.0